DBE 897 - error detected when {{US Flag|Virginia}} is used as value

Question

I've had a bunch of DBE 897 errors because of

invalid image type: parameter: destination-flag
{{Migrating Ancestor
| origin = England...

The value for that parameter (destination-flag) was {{US Flag|Virginia}} & I changed it to US_State_Flag_Images-49.png ... which the {{US Flag|Virginia}} template is meant to return, for use within a template.

Should that template - https://www.wikitree.com/wiki/Template:US_Flag - no longer be used?

Answer 1

That is a good point. All Flag templates return the image name. They are intended to be used within template definition, but it is nothing wrong in using them directly on the profile. I will adjust the checking of image parameters to allow use of the Flag template.

Comments

This is now implemented. Empty image and Flag templates are no longer reported as an error.

Main report list and WikiTree+ are updated. Country reports are not.

---

I am (still) getting the suggestion, eg on https://www.wikitree.com/wiki/Dijkstra-1020

Did you modify it to allow empty, or is the check now on a valid country-flag combination?

---

I had an expression wrong. I corrected it. Can you recheck next week.

---

On data set of Aug 30 I still get it on this profile [[Dijkstra-1020]] I might have made a mistake myself on it, but can't seem to determine what. Maybe the space after '=' ? (Just guessing though).

---

Suggestions are still being recalculated. I think 8 more hours.

---

Ah... I was under the impression today was a quick day.

Date of report: 2020-08-31 10:47:34 Date of Data: 30 Aug 2020

Maybe the Date of Data can be updated after the calculations have been redone? (Sorry, other request then)

---

That was a bug. It is now corrected.

---

Thanks.

The update is finished now and the suggestion 897 is gone

Answer 2

Are you using the template in the appropriate parameter field or using the 'value' that was returned?

The template page says it shouldn't be used on any profile.

Comments

I am using the US Flag template as intended... within another template.

The template on the profile that was reported in error:

{{Migrating Ancestor
| origin = England
| destination = Virginia
| origin-flag = Flags-3.jpg
| destination-flag = {{US Flag|Virginia}}
}}

It was the destination-flag parameter causing the error, as reported in the suggestion:

invalid image type: parameter: destination-flag

So I have replaced the {{US Flag|Virginia}} ... the profile's template is now:

{{Migrating Ancestor
| origin = England
| destination = Virginia
| origin-flag = Flags-3.jpg
| destination-flag = US_State_Flag_Images-49.png
}}

I won't know if that actually cleared the error till the next report.

I posted in G2G partly because if using the US Flag (and similar templates) as intended is going to cause a database error, that's a lot of editing to do or "False Suggestions" to mark & perhaps there's a way to exempt {{US Flag|...}} et al instead.

---

Hopefully Ales will check in when he sees the message since they recently updated templates and he has been updating the Suggestions. I tend to think he needs to 'tweak' his Suggestion a little.

---

DBE 897 is new - it was announced 2 August. See

https://www.wikitree.com/g2g/1084093/news-on-data-doctors-report-august-2nd-2020