I don't know enough to agree or disagree. So just for my own knowledge while appreciating your obvious frustration:
For example, let's say, my father served in WW2. He was in Unit xxxx what is the advantage of having his profile reside in Veterans, Unit xxxx, and in also in a different part of the category tree called Unit xxxx without veteran in the category name? It is obvious since there are no longer any active members of Unit xxxx for WW2 he is a veteran. Why do we need another branch of the category tree with the term "veteran" in it?
Why does removing the "veteran" categories and just changing the name to the plain unit # change the content?
Is this part of a project? If so, how do other project members feel?
I know this is frustrating when you see work you have done dismantled. But you should let us know what you think the advantages are for keeping it the way it is before we can agree/disagree with you. We need a list of reasons why it is important to keep the word "veterans" in the category name. You obviously think it adds some usefulness. We might agree with you if we knew what that usefulness is.
I think we all admire and applaud anyone (you) who is willing to devote time to figuring out some organization for the military categories. They are VERY confusing to a lay person and much previous discussion on Wikitree has dealt with the problems in how to categorize them.
I just need more information to discuss it with you.
Hang in there!