Seeing his name and your uncertainty about whether he was born in Pennsylvania or New Jersey, I think he might be a descendant of New Netherland settlers, possibly born in the "Minisink" area where New York, New Jersey, and Pennsylvania come together (and had border disputes), and where the old records usually did not mention the name of a particular colony or state. His birth name possibly could be Vandervere or a variant thereof.
But when I looked at his profile, I didn't see biography text to tell me the story of his life that you have been able to assemble. I suggest that you hone in on the basics -- create a narrative (in the text section of the profile) that describes the details of his life that you have assembled from records that you believe represent this man (remember that mistaken identities are possible). Do not include (and try not to think about) the relationships suggested in the family trees you've found online -- consider those to be hearsay that can steer us wrong.
From the sources that I can see in his profile, I see that a Silas York enlisted in the US Army on 27 July 1823, possibly at Philadelphia (it's hard to tell if the ditto marks apply to him) and was discharged "for deformity" in August 1823 (probably on the 10th -- the date isn't clear). If he had children born in Canada in 1814 through 1827 (as the profile indicates), this isn't him. I would be inclined to create another profile for this man using "Add > Unrelated Person," and make it a "Rejected Match" for your Silas.
And you have a land record in Ontario (I can't see a date for it) that says Silas Vandervere York was 33 years old, was born in New Jersey, was married with two children, and had lived 11 years in Ontario. That's an excellent source, but it needs a date and an indication of where it came from. If it was uploaded by an Ancestry user, have you tried to contact that user to find out where they got it? If you can get a date for this document, it should help you pin down an approximate birthdate, and thus help answer other questions.
Your biography of him could quote all or part of the April 1832 statement (in a book you linked to): "His Excellency the Lieutenant-Governor having authorized the examination of Silas V. York, a Discharged Soldier, and to Report thereon for his information, he received the following certificate by Order of the Board: 'This is to certify that Silas V. York, a corporal in the late Incorporated Regiment of Militia of Upper Canada [etc.]'"